Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve pdf preview #8615

Merged
merged 1 commit into from
Oct 29, 2024
Merged

chore: improve pdf preview #8615

merged 1 commit into from
Oct 29, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Oct 28, 2024 •
edited
Loading

  • caches image using ImageBitmap
  • resizes image using ImageBitmap
  • improves pages list render
  • supports file download
  • improves paging calculation
  • optimize list scrolling
  • adds flag to enable pdf preview

@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@fundon fundon mentioned this pull request Oct 28, 2024
Merged
@fundon Graphite App
Copy link
Contributor Author

fundon commented Oct 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon mentioned this pull request Oct 28, 2024
Merged
2 tasks
@fundon fundon marked this pull request as ready for review October 28, 2024 06:39
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 28, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0d57b01. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.30%. Comparing base (162958f) to head (0d57b01).
Report is 1 commits behind head on fundon/10_21_feat_pdf_preview.

Additional details and impacted files 
@@                        Coverage Diff                        @@
##           fundon/10_21_feat_pdf_preview    #8615      +/-   ##
=================================================================
+ Coverage                          70.11%   70.30%   +0.18%     
=================================================================
  Files                                536      536              
  Lines                              33700    33792      +92     
  Branches                            3023     3088      +65     
=================================================================
+ Hits                               23628    23756     +128     
+ Misses                              9717     9681      -36     
  Partials                             355      355
Flag Coverage Δ
server-test 77.16% <ø> (+0.14%) ⬆️
unittest 45.85% <ø> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/10_28_improve_pdf_preview branch from 2d34435 to b36bff9 Compare October 28, 2024 07:33
@fundon fundon force-pushed the fundon/10_28_improve_pdf_preview branch from b36bff9 to d77e2f1 Compare October 28, 2024 08:03
@fundon fundon force-pushed the fundon/10_28_improve_pdf_preview branch from d77e2f1 to aaea9d6 Compare October 28, 2024 08:17
@fundon fundon force-pushed the fundon/10_21_feat_pdf_preview branch from 67e0b8c to 6c1d599 Compare October 28, 2024 08:55
@fundon fundon force-pushed the fundon/10_28_improve_pdf_preview branch from aaea9d6 to 701d02a Compare October 28, 2024 08:55
@fundon fundon force-pushed the fundon/10_21_feat_pdf_preview branch from 6c1d599 to 3472add Compare October 28, 2024 09:14
@fundon fundon force-pushed the fundon/10_28_improve_pdf_preview branch from 701d02a to c0d6db6 Compare October 28, 2024 09:14
@EYHN EYHN force-pushed the fundon/10_21_feat_pdf_preview branch 2 times, most recently from bf29260 to 4f97399 Compare October 28, 2024 09:33
@EYHN EYHN force-pushed the fundon/10_28_improve_pdf_preview branch from c0d6db6 to ec799f1 Compare October 28, 2024 09:33
@fundon fundon force-pushed the fundon/10_28_improve_pdf_preview branch from c8661b8 to 5c04135 Compare October 28, 2024 23:35
@fundon fundon force-pushed the fundon/10_28_improve_pdf_preview branch from 5c04135 to 5cb1c8e Compare October 29, 2024 02:45
@fundon fundon force-pushed the fundon/10_28_improve_pdf_preview branch from 5cb1c8e to 78ae568 Compare October 29, 2024 02:46
@fundon fundon force-pushed the fundon/10_28_improve_pdf_preview branch from 78ae568 to 04b70d8 Compare October 29, 2024 05:14
@perfsee Perfsee
Copy link

perfsee bot commented Oct 29, 2024 •
edited
Loading

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                        EntryPoint: app                        @@
##                     canary …e_pdf_preview                 +/- ##
===================================================================
< Bundle              22.6 MB        24.1 MB    +1.45 MB(+6.42%)   
< Initial JS          9.63 MB        9.89 MB     +264 kB(+2.74%)   
> Initial CSS          256 kB         241 kB    -14.7 kB(-5.76%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   75             84                  +9   
< Chunks                   73             82                  +9   
< Packages                305            308                  +3   
= Duplicates               23             23                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting

@fundon fundon force-pushed the fundon/10_28_improve_pdf_preview branch from 04b70d8 to 0d57b01 Compare October 29, 2024 09:51
@fundon fundon merged commit 0d57b01 into fundon/10_21_feat_pdf_preview Oct 29, 2024
38 of 39 checks passed
@fundon fundon deleted the fundon/10_28_improve_pdf_preview branch October 29, 2024 10:19
This was referenced Nov 1, 2024
Open
Merged
This was referenced Nov 10, 2024
Merged
Closed
@forehalo forehalo mentioned this pull request Nov 11, 2024
Merged
This was referenced Nov 11, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EYHN EYHN EYHN left review comments

@forehalo forehalo Awaiting requested review from forehalo

@pengx17 pengx17 Awaiting requested review from pengx17

@CatsJuice CatsJuice Awaiting requested review from CatsJuice

@JimmFly JimmFly Awaiting requested review from JimmFly

Assignees
No one assigned
Labels
app:core mod:component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fundon @EYHN